HappenLee commented on code in PR #40162:
URL: https://github.com/apache/doris/pull/40162#discussion_r1740319357
##########
be/src/util/simd/vstring_function.h:
##########
@@ -187,6 +187,19 @@ class VStringFunctions {
return p;
}
+ static inline std::pair<size_t, size_t> skip_leading_utf8(const char*
begin, const char* end,
Review Comment:
Add comment and change the func name. we should know what the functinon do.
if just one place call the func, better be a lambda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
