github-actions[bot] commented on code in PR #40211:
URL: https://github.com/apache/doris/pull/40211#discussion_r1739612012
##########
be/src/vec/common/sort/sorter.cpp:
##########
@@ -135,9 +134,7 @@ Status MergeSorterState::_merge_sort_read_impl(int
batch_size, doris::vectorized
priority_queue_.push(current);
}
- if (merged_rows == batch_size) {
- break;
- }
+ if (merged_rows == batch_size) break;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (merged_rows == batch_size) { break;
}
```
##########
be/src/vec/runtime/vsorted_run_merger.cpp:
##########
@@ -28,6 +28,14 @@
#include "vec/core/column_with_type_and_name.h"
#include "vec/utils/util.hpp"
+namespace doris {
+namespace vectorized {
Review Comment:
warning: nested namespaces can be concatenated
[modernize-concat-nested-namespaces]
```suggestion
namespace doris::vectorized {
```
be/src/vec/runtime/vsorted_run_merger.cpp:33:
```diff
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris
```
##########
be/src/vec/runtime/vsorted_run_merger.h:
##########
@@ -30,7 +30,9 @@
#include "vec/core/sort_description.h"
#include "vec/exprs/vexpr_fwd.h"
-namespace doris::vectorized {
+namespace doris {
+
+namespace vectorized {
Review Comment:
warning: nested namespaces can be concatenated
[modernize-concat-nested-namespaces]
```suggestion
namespace doris::vectorized {
```
be/src/vec/runtime/vsorted_run_merger.h:107:
```diff
- } // namespace vectorized
- } // namespace doris
+ } // namespace doris
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
