TangSiyang2001 commented on code in PR #38489:
URL: https://github.com/apache/doris/pull/38489#discussion_r1740286561


##########
be/src/http/action/compaction_score_action.h:
##########


Review Comment:
   `show_hotspot_action` currently ony support cloud mode, and does not support 
sync_meta param we need in this action. If we use `show_hotspot_action`, we 
should firstly have a refactor on it to support both cloud and non-cloud mode, 
and add sync meta for cloud mode. Then we can move compaction score action into 
it.
   
   So do we need this work on `show_hotspot_action` or just keep this way for 
less modification?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to