xiaokang commented on code in PR #38908:
URL: https://github.com/apache/doris/pull/38908#discussion_r1727009376


##########
be/src/vec/exprs/vexpr_context.h:
##########
@@ -73,17 +188,13 @@ class VExprContext {
     // execute expr with inverted index which column a, b has inverted indexes
     //  but some situation although column b has indexes, but apply index is 
not useful, we should
     //  skip this expr, just do not apply index anymore.
-    /**
-     * @param colid_to_inverted_index_iter contains all column id to inverted 
index iterator mapping from segmentIterator
-     * @param num_rows number of rows in one segment.
-     * @param bitmap roaring bitmap to store the result. 0 is present filed by 
index.
-     * @return status not ok means execute failed.
-     */
-    [[nodiscard]] Status eval_inverted_index(
-            const std::unordered_map<ColumnId, 
std::pair<vectorized::IndexFieldNameAndTypePair,
-                                                         
segment_v2::InvertedIndexIterator*>>&
-                    colid_to_inverted_index_iter,
-            uint32_t num_rows, roaring::Roaring* bitmap);
+
+    [[nodiscard]] static Status evaluate_inverted_index(const 
VExprContextSPtrs& conjuncts,

Review Comment:
   Where is this funciton called?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to