zclllyybb commented on code in PR #40156: URL: https://github.com/apache/doris/pull/40156#discussion_r1736746560
########## be/src/vec/common/allocator.cpp: ########## @@ -79,6 +79,12 @@ void Allocator<clear_memory_, mmap_populate, use_mmap, MemoryAllocator>::sys_mem } } + // Find large memory allocation not catch exception + if (size > 10000 && !doris::enable_thread_catch_bad_alloc) { Review Comment: 这种基础的代码位置,是不是最好加个[[unlikely]] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org