github-actions[bot] commented on code in PR #40153:
URL: https://github.com/apache/doris/pull/40153#discussion_r1736599638
##########
be/src/exec/schema_scanner/schema_scanner_helper.h:
##########
@@ -0,0 +1,19 @@
+#ifndef _SCHEMA_SCANNER_HELPER_H_
+// this is a util class which can be used by all shema scanner
+// all common functions are added in this class.
+namespace doris {
+
+namespace vectorized {
+class Block;
+} // namespace vectorized
+class SchemaScannerHelper {
+public:
+ static void insert_string_value(int col_index, std::string str_val,
vectorized::Block* block);
Review Comment:
warning: use of undeclared identifier 'std' [clang-diagnostic-error]
```cpp
static void insert_string_value(int col_index, std::string str_val,
vectorized::Block* block);
^
```
##########
be/src/exec/schema_scanner/schema_scanner_helper.h:
##########
@@ -0,0 +1,19 @@
+#ifndef _SCHEMA_SCANNER_HELPER_H_
+// this is a util class which can be used by all shema scanner
+// all common functions are added in this class.
+namespace doris {
+
+namespace vectorized {
+class Block;
+} // namespace vectorized
+class SchemaScannerHelper {
+public:
+ static void insert_string_value(int col_index, std::string str_val,
vectorized::Block* block);
+ static void insert_datetime_value(int col_index, const std::vector<void*>&
datas,
+ vectorized::Block* block);
+
+ static void insert_int_value(int col_index, int64_t int_val,
vectorized::Block* block);
Review Comment:
warning: unknown type name 'int64_t' [clang-diagnostic-error]
```cpp
static void insert_int_value(int col_index, int64_t int_val,
vectorized::Block* block);
^
```
##########
be/src/exec/schema_scanner/schema_scanner_helper.h:
##########
@@ -0,0 +1,19 @@
+#ifndef _SCHEMA_SCANNER_HELPER_H_
+// this is a util class which can be used by all shema scanner
+// all common functions are added in this class.
+namespace doris {
+
+namespace vectorized {
+class Block;
+} // namespace vectorized
+class SchemaScannerHelper {
+public:
+ static void insert_string_value(int col_index, std::string str_val,
vectorized::Block* block);
+ static void insert_datetime_value(int col_index, const std::vector<void*>&
datas,
Review Comment:
warning: use of undeclared identifier 'std' [clang-diagnostic-error]
```cpp
static void insert_datetime_value(int col_index, const
std::vector<void*>& datas,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
