xzj7019 commented on code in PR #39450:
URL: https://github.com/apache/doris/pull/39450#discussion_r1735696994
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -293,6 +292,18 @@ public class Rewriter extends AbstractBatchJobExecutor {
topDown(new ConvertInnerOrCrossJoin()),
topDown(new
ProjectOtherJoinConditionForNestedLoopJoin())
),
+ topic("Set operation optimization",
+ // Do MergeSetOperation first because we hope to match
pattern of Distinct SetOperator.
+ topDown(new PushProjectThroughUnion(), new
MergeProjects()),
+ bottomUp(new MergeSetOperations(), new
MergeSetOperationsExcept()),
+ bottomUp(new PushProjectIntoOneRowRelation()),
+ topDown(new MergeOneRowRelationIntoUnion()),
+ topDown(new PushProjectIntoUnion()),
+ costBased(topDown(new InferSetOperatorDistinct())),
+ topDown(new BuildAggForUnion()),
+ bottomUp(new EliminateEmptyRelation()),
Review Comment:
pls add comments here to notice why another round of PushProjectIntoUnion
with preprocessing EliminateEmptyRelation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
