zddr commented on code in PR #38882:
URL: https://github.com/apache/doris/pull/38882#discussion_r1735669916


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/InitMaterializationContextHook.java:
##########
@@ -78,7 +78,8 @@ public void initMaterializationContext(CascadesContext 
cascadesContext) {
      * @param cascadesContext current cascadesContext in the planner
      */
     protected void doInitMaterializationContext(CascadesContext 
cascadesContext) {
-        TableCollectorContext collectorContext = new 
TableCollectorContext(Sets.newHashSet(), true);
+        TableCollectorContext collectorContext = new 
TableCollectorContext(Sets.newHashSet(),
+                true, true);

Review Comment:
   ditto



##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java:
##########
@@ -83,21 +81,30 @@ public static MTMVRelation generateMTMVRelation(MTMV mtmv, 
ConnectContext ctx) {
     }
 
     public static MTMVRelation generateMTMVRelation(Plan plan) {
-        return new MTMVRelation(getBaseTables(plan, true), getBaseTables(plan, 
false), getBaseViews(plan));
+        return new MTMVRelation(getBaseTables(plan, true, true),
+                getBaseTables(plan, false, false), getBaseViews(plan));

Review Comment:
   should explandView?otherwise,data change in baseTable,mv will not refresh 
auto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to