JNSimba commented on PR #23: URL: https://github.com/apache/incubator-doris-flink-connector/pull/23#issuecomment-1091163372
> > > > > There may have bugs when use `strip_outer_array` to load data using streaming, no data was loaded even if the result is successful. More importantly, we should not use `strip_ outer_ array` when load data using streaming. > > > > > > > > > > > > Thank you for your reply. I understand the bug that no data was loaded even if the result is successful, but don't understand why `strip_outer_array` cannot be used in stream processing? > > > > `strip_outer_array` > > > > > > > > > > > There may have bugs when use `strip_outer_array` to load data using streaming, no data was loaded even if the result is successful. More importantly, we should not use `strip_ outer_ array` when load data using streaming. > > > > > > > > > > > > Thank you for your reply. I understand the bug that no data was loaded even if the result is successful, but don't understand why `strip_outer_array` cannot be used in stream process > > > > > > > > > May generate a huge JSON array？ > > > > > > The `read_json_by_line` method should also have the problem of huge data? It is indeed more elegant to use the `read_json_by_line` parameter for the current `master` branch, but the new parameters and the historical version of the connector use parameters will become inconsistent, whether it will cause confusion to users, that is, `branch-for-flink-before-1.13` Branch code use parameters `strip_outer_array` , the `master` branch code uses the parameter `read_json_by_line`? > > `read_json_by_lines` is not necessary to load all data into memory, there are big configuration differences between branch-for-flink-before-1.13 and master. [DorisSinkProgrammingGuide.pdf](https://github.com/apache/incubator-doris-flink-connector/files/8438954/DorisSinkProgrammingGuide.pdf) ok i get it, thanks for your pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
