yiguolei commented on code in PR #39862:
URL: https://github.com/apache/doris/pull/39862#discussion_r1731181132


##########
be/src/runtime/memory/thread_mem_tracker_mgr.h:
##########
@@ -295,27 +296,47 @@ inline void ThreadMemTrackerMgr::flush_untracked_mem() {
     _stop_consume = false;
 }
 
-inline bool ThreadMemTrackerMgr::try_reserve(int64_t size) {
+inline doris::Status ThreadMemTrackerMgr::try_reserve(int64_t size, bool 
print_log) {

Review Comment:
   不要加print log的选项,加了实际跟没加没有区别,如果上层需要,那么他可以自己从打印status 获得。
   如果你认为需要print log,那么就直接在这个函数里print log 就可以了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to