xiaokang commented on code in PR #39841:
URL: https://github.com/apache/doris/pull/39841#discussion_r1730750723
##########
be/src/olap/rowset/segment_v2/hierarchical_data_reader.cpp:
##########
@@ -34,14 +36,15 @@ namespace segment_v2 {
Status HierarchicalDataReader::create(std::unique_ptr<ColumnIterator>* reader,
vectorized::PathInData path,
const SubcolumnColumnReaders::Node* node,
- const SubcolumnColumnReaders::Node*
root) {
+ const SubcolumnColumnReaders::Node* root,
+ const vectorized::DataTypePtr&
root_type) {
Review Comment:
root_type is not used
##########
be/src/olap/field.h:
##########
@@ -28,6 +28,7 @@
#include "olap/types.h"
#include "olap/utils.h"
#include "runtime/collection_value.h"
+#include "runtime/descriptors.h"
Review Comment:
unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
