github-actions[bot] commented on code in PR #39546: URL: https://github.com/apache/doris/pull/39546#discussion_r1730416338
########## be/test/vec/aggregate_functions/agg_linear_histogram_test.cpp: ########## @@ -0,0 +1,342 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <glog/logging.h> +#include <gtest/gtest-message.h> +#include <gtest/gtest-test-part.h> + +#include "gtest/gtest_pred_impl.h" +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/aggregate_function_simple_factory.h" +#include "vec/common/arena.h" +#include "vec/data_types/data_type_decimal.h" +#include "vec/data_types/data_type_number.h" + +namespace doris::vectorized { + +void register_aggregate_function_linear_histogram(AggregateFunctionSimpleFactory& factory); + +std::string s1 = + "{\"num_buckets\":10,\"buckets\":[" + "{\"lower\":0.0,\"upper\":10.0,\"count\":20,\"acc_count\":20}," + "{\"lower\":10.0,\"upper\":20.0,\"count\":20,\"acc_count\":40}," + "{\"lower\":20.0,\"upper\":30.0,\"count\":20,\"acc_count\":60}," + "{\"lower\":30.0,\"upper\":40.0,\"count\":20,\"acc_count\":80}," + "{\"lower\":40.0,\"upper\":50.0,\"count\":20,\"acc_count\":100}," + "{\"lower\":50.0,\"upper\":60.0,\"count\":20,\"acc_count\":120}," + "{\"lower\":60.0,\"upper\":70.0,\"count\":20,\"acc_count\":140}," + "{\"lower\":70.0,\"upper\":80.0,\"count\":20,\"acc_count\":160}," + "{\"lower\":80.0,\"upper\":90.0,\"count\":20,\"acc_count\":180}," + "{\"lower\":90.0,\"upper\":100.0,\"count\":20,\"acc_count\":200}" + "]}"; +std::string s2 = + "{\"num_buckets\":10,\"buckets\":[" + "{\"lower\":0.0,\"upper\":10.0,\"count\":10,\"acc_count\":10}," + "{\"lower\":10.0,\"upper\":20.0,\"count\":10,\"acc_count\":20}," + "{\"lower\":20.0,\"upper\":30.0,\"count\":10,\"acc_count\":30}," + "{\"lower\":30.0,\"upper\":40.0,\"count\":10,\"acc_count\":40}," + "{\"lower\":40.0,\"upper\":50.0,\"count\":10,\"acc_count\":50}," + "{\"lower\":50.0,\"upper\":60.0,\"count\":10,\"acc_count\":60}," + "{\"lower\":60.0,\"upper\":70.0,\"count\":10,\"acc_count\":70}," + "{\"lower\":70.0,\"upper\":80.0,\"count\":10,\"acc_count\":80}," + "{\"lower\":80.0,\"upper\":90.0,\"count\":10,\"acc_count\":90}," + "{\"lower\":90.0,\"upper\":100.0,\"count\":10,\"acc_count\":100}" + "]}"; +std::string s3 = + "{\"num_buckets\":11,\"buckets\":[" + "{\"lower\":-5.0,\"upper\":5.0,\"count\":10,\"acc_count\":10}," + "{\"lower\":5.0,\"upper\":15.0,\"count\":20,\"acc_count\":30}," + "{\"lower\":15.0,\"upper\":25.0,\"count\":20,\"acc_count\":50}," + "{\"lower\":25.0,\"upper\":35.0,\"count\":20,\"acc_count\":70}," + "{\"lower\":35.0,\"upper\":45.0,\"count\":20,\"acc_count\":90}," + "{\"lower\":45.0,\"upper\":55.0,\"count\":20,\"acc_count\":110}," + "{\"lower\":55.0,\"upper\":65.0,\"count\":20,\"acc_count\":130}," + "{\"lower\":65.0,\"upper\":75.0,\"count\":20,\"acc_count\":150}," + "{\"lower\":75.0,\"upper\":85.0,\"count\":20,\"acc_count\":170}," + "{\"lower\":85.0,\"upper\":95.0,\"count\":20,\"acc_count\":190}," + "{\"lower\":95.0,\"upper\":105.0,\"count\":10,\"acc_count\":200}" + "]}"; +std::string s4 = + "{\"num_buckets\":11,\"buckets\":[" + "{\"lower\":-5.0,\"upper\":5.0,\"count\":5,\"acc_count\":5}," + "{\"lower\":5.0,\"upper\":15.0,\"count\":10,\"acc_count\":15}," + "{\"lower\":15.0,\"upper\":25.0,\"count\":10,\"acc_count\":25}," + "{\"lower\":25.0,\"upper\":35.0,\"count\":10,\"acc_count\":35}," + "{\"lower\":35.0,\"upper\":45.0,\"count\":10,\"acc_count\":45}," + "{\"lower\":45.0,\"upper\":55.0,\"count\":10,\"acc_count\":55}," + "{\"lower\":55.0,\"upper\":65.0,\"count\":10,\"acc_count\":65}," + "{\"lower\":65.0,\"upper\":75.0,\"count\":10,\"acc_count\":75}," + "{\"lower\":75.0,\"upper\":85.0,\"count\":10,\"acc_count\":85}," + "{\"lower\":85.0,\"upper\":95.0,\"count\":10,\"acc_count\":95}," + "{\"lower\":95.0,\"upper\":105.0,\"count\":5,\"acc_count\":100}" + "]}"; +std::string s5 = + "{\"num_buckets\":9,\"buckets\":[" + "{\"lower\":0.0,\"upper\":0.5,\"count\":2,\"acc_count\":2}," + "{\"lower\":0.5,\"upper\":1.0,\"count\":0,\"acc_count\":2}," + "{\"lower\":1.0,\"upper\":1.5,\"count\":2,\"acc_count\":4}," + "{\"lower\":1.5,\"upper\":2.0,\"count\":0,\"acc_count\":4}," + "{\"lower\":2.0,\"upper\":2.5,\"count\":2,\"acc_count\":6}," + "{\"lower\":2.5,\"upper\":3.0,\"count\":0,\"acc_count\":6}," + "{\"lower\":3.0,\"upper\":3.5,\"count\":2,\"acc_count\":8}," + "{\"lower\":3.5,\"upper\":4.0,\"count\":0,\"acc_count\":8}," + "{\"lower\":4.0,\"upper\":4.5,\"count\":2,\"acc_count\":10}" + "]}"; +std::string s6 = + "{\"num_buckets\":9,\"buckets\":[" + "{\"lower\":0.0,\"upper\":0.5,\"count\":1,\"acc_count\":1}," + "{\"lower\":0.5,\"upper\":1.0,\"count\":0,\"acc_count\":1}," + "{\"lower\":1.0,\"upper\":1.5,\"count\":1,\"acc_count\":2}," + "{\"lower\":1.5,\"upper\":2.0,\"count\":0,\"acc_count\":2}," + "{\"lower\":2.0,\"upper\":2.5,\"count\":1,\"acc_count\":3}," + "{\"lower\":2.5,\"upper\":3.0,\"count\":0,\"acc_count\":3}," + "{\"lower\":3.0,\"upper\":3.5,\"count\":1,\"acc_count\":4}," + "{\"lower\":3.5,\"upper\":4.0,\"count\":0,\"acc_count\":4}," + "{\"lower\":4.0,\"upper\":4.5,\"count\":1,\"acc_count\":5}" + "]}"; +std::string s7 = + "{\"num_buckets\":9,\"buckets\":[" + "{\"lower\":-0.25,\"upper\":0.25,\"count\":2,\"acc_count\":2}," + "{\"lower\":0.25,\"upper\":0.75,\"count\":0,\"acc_count\":2}," + "{\"lower\":0.75,\"upper\":1.25,\"count\":2,\"acc_count\":4}," + "{\"lower\":1.25,\"upper\":1.75,\"count\":0,\"acc_count\":4}," + "{\"lower\":1.75,\"upper\":2.25,\"count\":2,\"acc_count\":6}," + "{\"lower\":2.25,\"upper\":2.75,\"count\":0,\"acc_count\":6}," + "{\"lower\":2.75,\"upper\":3.25,\"count\":2,\"acc_count\":8}," + "{\"lower\":3.25,\"upper\":3.75,\"count\":0,\"acc_count\":8}," + "{\"lower\":3.75,\"upper\":4.25,\"count\":2,\"acc_count\":10}" + "]}"; +std::string s8 = + "{\"num_buckets\":9,\"buckets\":[" + "{\"lower\":-0.25,\"upper\":0.25,\"count\":1,\"acc_count\":1}," + "{\"lower\":0.25,\"upper\":0.75,\"count\":0,\"acc_count\":1}," + "{\"lower\":0.75,\"upper\":1.25,\"count\":1,\"acc_count\":2}," + "{\"lower\":1.25,\"upper\":1.75,\"count\":0,\"acc_count\":2}," + "{\"lower\":1.75,\"upper\":2.25,\"count\":1,\"acc_count\":3}," + "{\"lower\":2.25,\"upper\":2.75,\"count\":0,\"acc_count\":3}," + "{\"lower\":2.75,\"upper\":3.25,\"count\":1,\"acc_count\":4}," + "{\"lower\":3.25,\"upper\":3.75,\"count\":0,\"acc_count\":4}," + "{\"lower\":3.75,\"upper\":4.25,\"count\":1,\"acc_count\":5}" + "]}"; + +class AggLinearHistogramTest : public testing::Test { +public: + void SetUp() override { + AggregateFunctionSimpleFactory factory = AggregateFunctionSimpleFactory::instance(); + register_aggregate_function_linear_histogram(factory); + } + + void TearDown() override {} + + template <typename DataType> + void agg_linear_histogram_add_elements(AggregateFunctionPtr agg_function, + AggregateDataPtr place, size_t input_rows, + double interval, double offset) { + using FieldType = typename DataType::FieldType; + + std::shared_ptr<DataType> type; + if constexpr (IsDecimalNumber<FieldType>) { + type = std::make_shared<DataType>(9, 0); + } else { + type = std::make_shared<DataType>(); + } + + MutableColumns columns(3); + columns[0] = type->create_column(); + columns[1] = ColumnFloat64::create(); + columns[2] = ColumnFloat64::create(); + + for (size_t i = 0; i < input_rows; ++i) { + auto item0 = FieldType(static_cast<uint64_t>(i)); + columns[0]->insert_data(reinterpret_cast<const char*>(&item0), 0); + columns[1]->insert_data(reinterpret_cast<const char*>(&interval), 0); + if (offset != 0) { + columns[2]->insert_data(reinterpret_cast<const char*>(&offset), 0); + } + } + + EXPECT_EQ(columns[0]->size(), input_rows); + + if (offset != 0) { + const IColumn* column[3] = {columns[0].get(), columns[1].get(), columns[2].get()}; + for (int i = 0; i < input_rows; i++) { + agg_function->add(place, column, i, &_agg_arena_pool); + } + } else { + const IColumn* column[2] = {columns[0].get(), columns[1].get()}; + for (int i = 0; i < input_rows; i++) { + agg_function->add(place, column, i, &_agg_arena_pool); + } + } + } + + template <typename DataType> + void test_agg_linear_histogram(size_t input_rows, double interval, double offset) { Review Comment: warning: function 'test_agg_linear_histogram' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void test_agg_linear_histogram(size_t input_rows, double interval, double offset) { ^ ``` <details> <summary>Additional context</summary> **be/test/vec/aggregate_functions/agg_linear_histogram_test.cpp:187:** 100 lines including whitespace and comments (threshold 80) ```cpp void test_agg_linear_histogram(size_t input_rows, double interval, double offset) { ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
