github-actions[bot] commented on code in PR #39772:
URL: https://github.com/apache/doris/pull/39772#discussion_r1726485336
##########
be/src/io/fs/benchmark/hdfs_file_writer_benchmark.cpp:
##########
@@ -0,0 +1,151 @@
+#include <bthread/countdown_event.h>
+#include <cpp/sync_point.h>
+#include <gen_cpp/PlanNodes_types.h>
+#include <gflags/gflags.h>
+
+#include <thread>
+
+#include "common/logging.h"
+#include "io/fs/file_writer.h"
+#include "io/fs/hdfs_file_system.h"
+#include "runtime/exec_env.h"
+#include "util/jvm_metrics.h"
+#include "util/threadpool.h"
+
+using namespace doris;
+
+DEFINE_string(fs_name, "", "hdfs fs name");
+DEFINE_string(path_prefix, "/hdfs_file_writer_bench", "hdfs path prefix");
+DEFINE_int32(num_files, 32, "number of files to write");
+DEFINE_uint64(file_size, 10 * 1024 * 1024 /* 10MB */, "size of each file");
+DEFINE_int32(parallel, 16, "number of parallel writers");
+DEFINE_int32(flush_delay, 0, "delay in ms when flushing data to HDFS");
+
+namespace doris::io {
+extern bvar::Adder<uint64_t> hdfs_write_acquire_memory_failed;
+extern bvar::Adder<uint64_t> hdfs_write_acquire_memory_reach_max_retry;
+} // namespace doris::io
+
+void run_benchmark(io::HdfsFileSystem& fs, int num_files, size_t file_size,
int parallel,
Review Comment:
warning: function 'run_benchmark' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
void run_benchmark(io::HdfsFileSystem& fs, int num_files, size_t file_size,
int parallel,
^
```
<details>
<summary>Additional context</summary>
**be/src/io/fs/benchmark/hdfs_file_writer_benchmark.cpp:28:** 82 lines
including whitespace and comments (threshold 80)
```cpp
void run_benchmark(io::HdfsFileSystem& fs, int num_files, size_t file_size,
int parallel,
^
```
</details>
##########
be/src/io/fs/benchmark/hdfs_file_writer_benchmark.cpp:
##########
@@ -0,0 +1,151 @@
+#include <bthread/countdown_event.h>
Review Comment:
warning: 'bthread/countdown_event.h' file not found [clang-diagnostic-error]
```cpp
#include <bthread/countdown_event.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
