w41ter commented on code in PR #38243:
URL: https://github.com/apache/doris/pull/38243#discussion_r1722598237
##########
be/src/cloud/config.h:
##########
@@ -94,4 +94,6 @@ DECLARE_mBool(save_load_error_log_to_s3);
// the theads which sync the datas which loaded in other clusters
DECLARE_mInt32(sync_load_for_tablets_thread);
+DECLARE_mBool(txn_lazy_commit);
Review Comment:
Add `cloud_` prefix, and add a description too.
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -618,11 +649,13 @@ void
MetaServiceImpl::create_tablets(::google::protobuf::RpcController* controll
msg = fmt::format("failed to get vault id, vault name={}", name);
return;
}
+ DCHECK(request->has_db_id());
Review Comment:
What happens if the doris FE is the old version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
