HappenLee commented on code in PR #39550: URL: https://github.com/apache/doris/pull/39550#discussion_r1721795444
########## be/src/pipeline/exec/scan_operator.cpp: ########## @@ -708,7 +716,9 @@ Status ScanLocalState<Derived>::_should_push_down_binary_predicate( std::shared_ptr<ColumnPtrWrapper> const_col_wrapper; RETURN_IF_ERROR(children[1 - i]->get_const_col(expr_ctx, &const_col_wrapper)); if (const auto* const_column = check_and_get_column<vectorized::ColumnConst>( - const_col_wrapper->column_ptr)) { + const_col_wrapper->column_ptr); + const_column && !const_column->is_null_at(0)) { + // It is possible that the result of the cast might be null Review Comment: the change way is bad performance,we should find a better way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org