SWJTU-ZhangLei commented on code in PR #39372:
URL: https://github.com/apache/doris/pull/39372#discussion_r1721114208


##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -180,6 +180,7 @@ protected Partition createPartitionWithIndices(long dbId, 
OlapTable tbl, long pa
             if (!storageVaultIdSet && ((CloudEnv) 
Env.getCurrentEnv()).getEnableStorageVault()) {
                 requestBuilder.setStorageVaultName(storageVaultName);
             }
+            requestBuilder.setDbId(dbId);

Review Comment:
   > Consider checking the db id in method `Cloud.CreateTabletsResponse 
sendCreateTabletsRpc(Cloud.CreateTabletsRequest.Builder requestBuilder)`, 
throws `Exception` if this field is not set.
   
   done, add a precondition check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to