zhiqiang-hhhh commented on code in PR #38548:
URL: https://github.com/apache/doris/pull/38548#discussion_r1720755429


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/EnvFactory.java:
##########
@@ -140,9 +140,10 @@ public Coordinator createCoordinator(ConnectContext 
context, Analyzer analyzer,
     // Used for broker load task/export task/update coordinator
     public Coordinator createCoordinator(Long jobId, TUniqueId queryId, 
DescriptorTable descTable,
                                          List<PlanFragment> fragments, 
List<ScanNode> scanNodes,
-                                         String timezone, boolean 
loadZeroTolerance, boolean enableProfile) {
+                                         String timezone, boolean 
loadZeroTolerance, boolean enableProfile,
+                                         long autoProfileThresholdMs) {

Review Comment:
   > coord 里的这些参数,为什么不通过query options 来传递? 当前这种改法,如果增加更多的参数的话,coord的参数列表太长了
   
   比如 loadloading task 在创建的时候之前的 connection ctx 已经不见了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to