yiguolei commented on code in PR #39520:
URL: https://github.com/apache/doris/pull/39520#discussion_r1720753123
##########
be/src/http/action/check_rpc_channel_action.cpp:
##########
@@ -38,7 +38,8 @@
namespace doris {
CheckRPCChannelAction::CheckRPCChannelAction(ExecEnv* exec_env,
TPrivilegeHier::type hier,
TPrivilegeType::type type)
- : HttpHandlerWithAuth(exec_env, hier, type) {}
+ : HttpHandlerWithAuth(exec_env, hier, type), _exec_env(exec_env) {}
Review Comment:
There is already a Exec_env member in HttpHandlerWithAuth. Why not change
it to protected and delete the _exec_env member in CheckRPCChannelAction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
