morrySnow commented on code in PR #36525:
URL: https://github.com/apache/doris/pull/36525#discussion_r1718442488
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowConfigStmt.java:
##########
@@ -17,67 +17,94 @@
package org.apache.doris.analysis;
-import org.apache.doris.analysis.AdminSetConfigStmt.ConfigType;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.ScalarType;
-import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
import org.apache.doris.common.UserException;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.ShowResultSetMetaData;
+import org.apache.doris.system.NodeType;
import com.google.common.collect.ImmutableList;
// show frontend config;
public class ShowConfigStmt extends ShowStmt {
Review Comment:
```suggestion
public class ShowConfigStmt extends ShowStmt implements NotFallbackInParser {
```
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -40,6 +40,7 @@ statement
| DROP (PROCEDURE | PROC) (IF EXISTS)? name=multipartIdentifier
#dropProcedure
| SHOW PROCEDURE STATUS (LIKE pattern=valueExpression | whereClause)?
#showProcedureStatus
| SHOW CREATE PROCEDURE name=multipartIdentifier #showCreateProcedure
+ | SHOW type=(FRONTEND | BACKEND) CONFIG (LIKE pattern=valueExpression)?
(FROM backendId=INTEGER_VALUE)? #showConfig
Review Comment:
```suggestion
| ADMIN? SHOW type=(FRONTEND | BACKEND) CONFIG (LIKE
pattern=valueExpression)? (FROM backendId=INTEGER_VALUE)? #showConfig
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
