github-actions[bot] commented on code in PR #39372:
URL: https://github.com/apache/doris/pull/39372#discussion_r1718035453
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -403,9 +403,9 @@ void
MetaServiceImpl::batch_get_version(::google::protobuf::RpcController* contr
}
}
-void internal_create_tablet(MetaServiceCode& code, std::string& msg,
- const doris::TabletMetaCloudPB& meta,
std::shared_ptr<TxnKv> txn_kv,
- const std::string& instance_id,
+void internal_create_tablet(const CreateTabletsRequest* request,
MetaServiceCode& code,
Review Comment:
warning: function 'internal_create_tablet' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void internal_create_tablet(const CreateTabletsRequest* request,
MetaServiceCode& code,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service.cpp:405:** 130 lines including
whitespace and comments (threshold 80)
```cpp
void internal_create_tablet(const CreateTabletsRequest* request,
MetaServiceCode& code,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
