gavinchou commented on code in PR #39388:
URL: https://github.com/apache/doris/pull/39388#discussion_r1718034427
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -1259,6 +1259,22 @@ void commit_txn_immediately(
// Finally we are done...
err = txn->commit();
if (err != TxnErrorCode::TXN_OK) {
+ if (err == TxnErrorCode::TXN_VALUE_TOO_LARGE || err ==
TxnErrorCode::TXN_BYTES_TOO_LARGE) {
+ DCHECK(!tmp_rowsets_meta.empty());
Review Comment:
it's better to return log warning directly instead of DCHECK and continue to
dereferencing tmp_rowset_meta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
