yiguolei commented on code in PR #39374: URL: https://github.com/apache/doris/pull/39374#discussion_r1717048034
########## be/src/agent/cgroup_cpu_ctl.cpp: ########## @@ -19,31 +19,106 @@ #include <fmt/format.h> #include <sys/stat.h> +#include <unistd.h> #include <filesystem> +#include "util/cgroup_util.h" #include "util/defer_op.h" namespace doris { -Status CgroupCpuCtl::init() { - _doris_cgroup_cpu_path = config::doris_cgroup_cpu_path; - if (_doris_cgroup_cpu_path.empty()) { - LOG(INFO) << "doris cgroup cpu path is not specify, path=" << _doris_cgroup_cpu_path; - return Status::InvalidArgument<false>("doris cgroup cpu path {} is not specify.", - _doris_cgroup_cpu_path); +bool CgroupCpuCtl::is_a_valid_cgroup_path(std::string cg_path) { Review Comment: 把这个方法在be test 里增加一个ut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org