github-actions[bot] commented on code in PR #38243: URL: https://github.com/apache/doris/pull/38243#discussion_r1714974008
########## cloud/src/meta-service/txn_lazy_committer.cpp: ########## @@ -0,0 +1,455 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "txn_lazy_committer.h" + +#include <chrono> + +#include "common/logging.h" +#include "common/util.h" +#include "meta-service/keys.h" +#include "meta-service/meta_service_helper.h" +#include "meta-service/meta_service_tablet_stats.h" + +using namespace std::chrono; + +namespace doris::cloud { + +void scan_tmp_rowset( + const std::string& instance_id, int64_t txn_id, std::shared_ptr<TxnKv> txn_kv, + MetaServiceCode& code, std::string& msg, int64_t* db_id, + std::vector<std::pair<std::string, doris::RowsetMetaCloudPB>>* tmp_rowsets_meta); + +void update_tablet_stats(const StatsTabletKeyInfo& info, const TabletStats& stats, Review Comment: warning: function 'convert_tmp_rowsets' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void convert_tmp_rowsets( ^ ``` <details> <summary>Additional context</summary> **cloud/src/meta-service/txn_lazy_committer.cpp:36:** 152 lines including whitespace and comments (threshold 80) ```cpp void convert_tmp_rowsets( ^ ``` </details> ########## cloud/src/meta-service/txn_lazy_committer.cpp: ########## @@ -0,0 +1,455 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "txn_lazy_committer.h" + +#include <chrono> + +#include "common/logging.h" +#include "common/util.h" +#include "meta-service/keys.h" +#include "meta-service/meta_service_helper.h" +#include "meta-service/meta_service_tablet_stats.h" + +using namespace std::chrono; + +namespace doris::cloud { + +void scan_tmp_rowset( + const std::string& instance_id, int64_t txn_id, std::shared_ptr<TxnKv> txn_kv, + MetaServiceCode& code, std::string& msg, int64_t* db_id, + std::vector<std::pair<std::string, doris::RowsetMetaCloudPB>>* tmp_rowsets_meta); + +void update_tablet_stats(const StatsTabletKeyInfo& info, const TabletStats& stats, + std::unique_ptr<Transaction>& txn, MetaServiceCode& code, + std::string& msg); + +void convert_tmp_rowsets( + const std::string& instance_id, int64_t txn_id, std::shared_ptr<TxnKv> txn_kv, + MetaServiceCode& code, std::string& msg, int64_t db_id, + std::vector<std::pair<std::string, doris::RowsetMetaCloudPB>>& tmp_rowsets_meta, + std::unordered_map<int64_t, TabletIndexPB>& tablet_ids) { + std::stringstream ss; + std::unique_ptr<Transaction> txn; + TxnErrorCode err = txn_kv->create_txn(&txn); + if (err != TxnErrorCode::TXN_OK) { + code = cast_as<ErrCategory::CREATE>(err); + ss << "failed to create txn, txn_id=" << txn_id << " err=" << err; + msg = ss.str(); + LOG(WARNING) << msg; + return; + } + + // partition_id -> VersionPB + std::unordered_map<int64_t, VersionPB> partition_versions; + // tablet_id -> stats + std::unordered_map<int64_t, TabletStats> tablet_stats; + + for (auto& [tmp_rowset_key, tmp_rowset_pb] : tmp_rowsets_meta) { + std::string tmp_rowst_data; + err = txn->get(tmp_rowset_key, &tmp_rowst_data); + if (TxnErrorCode::TXN_KEY_NOT_FOUND == err) { + // the tmp rowset has been converted + VLOG_DEBUG << "tmp rowset has been converted, key=" << hex(tmp_rowset_key); + continue; + } + + if (TxnErrorCode::TXN_OK != err) { + code = cast_as<ErrCategory::READ>(err); + ss << "failed to get tmp_rowset_key, txn_id=" << txn_id + << " key=" << hex(tmp_rowset_key) << " err=" << err; + msg = ss.str(); + LOG(WARNING) << msg; + return; + } + + if (!tablet_ids.contains(tmp_rowset_pb.tablet_id())) { + std::string tablet_idx_key = + meta_tablet_idx_key({instance_id, tmp_rowset_pb.tablet_id()}); + std::string tablet_idx_val; + err = txn->get(tablet_idx_key, &tablet_idx_val, true); + if (TxnErrorCode::TXN_OK != err) { + code = err == TxnErrorCode::TXN_KEY_NOT_FOUND ? MetaServiceCode::TXN_ID_NOT_FOUND + : cast_as<ErrCategory::READ>(err); + ss << "failed to get tablet idx, txn_id=" << txn_id + << " key=" << hex(tablet_idx_key) << " err=" << err; + msg = ss.str(); + LOG(WARNING) << msg; + return; + } + + TabletIndexPB tablet_idx_pb; + if (!tablet_idx_pb.ParseFromString(tablet_idx_val)) { + code = MetaServiceCode::PROTOBUF_PARSE_ERR; + ss << "failed to parse tablet idx pb txn_id=" << txn_id + << " key=" << hex(tablet_idx_key); + msg = ss.str(); + return; + } + tablet_ids.emplace(tmp_rowset_pb.tablet_id(), tablet_idx_pb); + } + const TabletIndexPB& tablet_idx_pb = tablet_ids[tmp_rowset_pb.tablet_id()]; + + if (!partition_versions.contains(tmp_rowset_pb.partition_id())) { + std::string ver_val; + std::string ver_key = partition_version_key( + {instance_id, db_id, tablet_idx_pb.table_id(), tmp_rowset_pb.partition_id()}); + err = txn->get(ver_key, &ver_val); + if (TxnErrorCode::TXN_OK != err) { + code = err == TxnErrorCode::TXN_KEY_NOT_FOUND ? MetaServiceCode::TXN_ID_NOT_FOUND + : cast_as<ErrCategory::READ>(err); + ss << "failed to get partiton version, txn_id=" << txn_id << " key=" << hex(ver_key) + << " err=" << err; + msg = ss.str(); + LOG(WARNING) << msg; + return; + } + VersionPB version_pb; + if (!version_pb.ParseFromString(ver_val)) { + code = MetaServiceCode::PROTOBUF_PARSE_ERR; + ss << "failed to parse version pb txn_id=" << txn_id << " key=" << hex(ver_key); + msg = ss.str(); + return; + } + LOG(INFO) << "txn_id=" << txn_id << " key=" << hex(ver_key) + << " version_pb:" << version_pb.ShortDebugString(); + DCHECK(version_pb.has_txn_id()); + DCHECK(version_pb.txn_id() == txn_id); + partition_versions.emplace(tmp_rowset_pb.partition_id(), version_pb); + } + + const VersionPB& version_pb = partition_versions[tmp_rowset_pb.partition_id()]; + + std::string rowset_key = + meta_rowset_key({instance_id, tmp_rowset_pb.tablet_id(), version_pb.version()}); + std::string rowset_val; + err = txn->get(rowset_key, &rowset_val); + if (TxnErrorCode::TXN_OK == err) { + continue; + } + + if (err != TxnErrorCode::TXN_KEY_NOT_FOUND) { + code = cast_as<ErrCategory::READ>(err); + ss << "failed to get rowset_key, txn_id=" << txn_id << " key=" << hex(rowset_key) + << " err=" << err; + msg = ss.str(); + LOG(WARNING) << msg; + return; + } + DCHECK(err == TxnErrorCode::TXN_KEY_NOT_FOUND); + + tmp_rowset_pb.set_start_version(version_pb.version()); + tmp_rowset_pb.set_end_version(version_pb.version()); + + rowset_val.clear(); + if (!tmp_rowset_pb.SerializeToString(&rowset_val)) { + code = MetaServiceCode::PROTOBUF_SERIALIZE_ERR; + ss << "failed to serialize rowset_meta, txn_id=" << txn_id + << " key=" << hex(rowset_key); + msg = ss.str(); + return; + } + + txn->put(rowset_key, rowset_val); + LOG(INFO) << "xxx put rowset_key=" << hex(rowset_key) << " txn_id=" << txn_id + << " rowset_size=" << rowset_key.size() + rowset_val.size(); + + // Accumulate affected rows + auto& stats = tablet_stats[tmp_rowset_pb.tablet_id()]; + stats.data_size += tmp_rowset_pb.data_disk_size(); + stats.num_rows += tmp_rowset_pb.num_rows(); + ++stats.num_rowsets; + stats.num_segs += tmp_rowset_pb.num_segments(); + } + + DCHECK(partition_versions.size() == 1); + + for (auto& [tablet_id, stats] : tablet_stats) { + DCHECK(tablet_ids.count(tablet_id)); + auto& tablet_idx = tablet_ids[tablet_id]; + StatsTabletKeyInfo info {instance_id, tablet_idx.table_id(), tablet_idx.index_id(), + tablet_idx.partition_id(), tablet_id}; + update_tablet_stats(info, stats, txn, code, msg); + if (code != MetaServiceCode::OK) return; + } + + err = txn->commit(); + if (err != TxnErrorCode::TXN_OK) { + code = cast_as<ErrCategory::COMMIT>(err); + ss << "failed to commit kv txn, txn_id=" << txn_id << " err=" << err; + msg = ss.str(); + return; + } +} + +void make_committed_txn_visible(const std::string& instance_id, int64_t db_id, int64_t txn_id, + std::shared_ptr<TxnKv> txn_kv, MetaServiceCode& code, + std::string& msg) { + // 1. visible txn info + // 2. remove running key and put recycle txn key + + std::stringstream ss; + std::unique_ptr<Transaction> txn; + TxnErrorCode err = txn_kv->create_txn(&txn); + if (err != TxnErrorCode::TXN_OK) { + code = cast_as<ErrCategory::CREATE>(err); Review Comment: warning: function 'commit' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void TxnLazyCommitTask::commit() { ^ ``` <details> <summary>Additional context</summary> **cloud/src/meta-service/txn_lazy_committer.cpp:208:** 122 lines including whitespace and comments (threshold 80) ```cpp void TxnLazyCommitTask::commit() { ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
