amorynan commented on code in PR #39258:
URL: https://github.com/apache/doris/pull/39258#discussion_r1714623378
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -70,12 +71,14 @@ Status SegmentFlusher::flush_single_block(const
vectorized::Block* block, int32_
_context.tablet_schema->cluster_key_idxes().empty()) {
std::unique_ptr<segment_v2::VerticalSegmentWriter> writer;
RETURN_IF_ERROR(_create_segment_writer(writer, segment_id,
no_compression));
- RETURN_IF_ERROR(_add_rows(writer, &flush_block, 0,
flush_block.rows()));
+ HANDLE_EXCEPTION_IF_CATCH_EXCEPTION(_add_rows(writer, &flush_block, 0,
flush_block.rows()),
+ [&](const doris::Exception& ex)
{});
RETURN_IF_ERROR(_flush_segment_writer(writer, writer->flush_schema(),
flush_size));
} else {
std::unique_ptr<segment_v2::SegmentWriter> writer;
RETURN_IF_ERROR(_create_segment_writer(writer, segment_id,
no_compression));
- RETURN_IF_ERROR(_add_rows(writer, &flush_block, 0,
flush_block.rows()));
+ HANDLE_EXCEPTION_IF_CATCH_EXCEPTION(_add_rows(writer, &flush_block, 0,
flush_block.rows()),
Review Comment:
we should use RETURN_IF_ERROR_OR_CATCH_EXCEPTION, _add_rows will return
status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
