yiguolei commented on code in PR #39256:
URL: https://github.com/apache/doris/pull/39256#discussion_r1714198924
##########
be/src/util/mem_info.cpp:
##########
@@ -194,65 +194,28 @@ void MemInfo::refresh_proc_meminfo() {
int64_t cgroup_mem_usage = -1;
std::string cgroup_mem_info_file_path;
_s_cgroup_mem_refresh_state = true;
- Status status = CGroupUtil::find_cgroup_mem_limit(&cgroup_mem_limit);
+ Status status =
CGroupMemoryCtl::find_cgroup_mem_limit(&cgroup_mem_limit);
if (!status.ok() || cgroup_mem_limit <= 0) {
_s_cgroup_mem_refresh_state = false;
}
- status = CGroupUtil::find_cgroup_mem_usage(&cgroup_mem_usage);
+ status = CGroupMemoryCtl::find_cgroup_mem_usage(&cgroup_mem_usage);
if (!status.ok() || cgroup_mem_usage <= 0) {
_s_cgroup_mem_refresh_state = false;
}
- status = CGroupUtil::find_cgroup_mem_info(&cgroup_mem_info_file_path);
Review Comment:
最好把这个方法抽出来，作为一个单独的方法。
然后我们从拿一个文件，放到单测里，去测试一下我们能否正确解析这些文件。
CPU 那里也是这样。
不论是memory和cpu controller，他们的路径可能不一样，但是一旦文件路径确定了，实际就跟cgroup
没什么关系，我们做的就是读取文件，解析文件内容的活。
这里的变动很基础，一个不小心容易错，然后就各种cancel。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
