zhiqiang-hhhh commented on code in PR #39223: URL: https://github.com/apache/doris/pull/39223#discussion_r1713741238
########## be/src/runtime/fragment_mgr.cpp: ########## @@ -133,6 +136,95 @@ std::string to_load_error_http_path(const std::string& file_name) { using apache::thrift::TException; using apache::thrift::transport::TTransportException; +static bool _get_all_running_queries(std::unordered_set<TUniqueId>& result_ref) { Review Comment: 这里得把所有FE按一个整体去考虑。发往FE的rpc里,只要有任何一个出现异常或者返回状态不是 OK,那么这个函数就会返回 false。cancel worker 线程就会放弃本次的 pipeline task 泄漏检查。因为如果不这么做的话,我们拿到的 `map<TUniqueId>` 很可能是不全的,就会有误cancel的情况。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org