morrySnow commented on code in PR #39229: URL: https://github.com/apache/doris/pull/39229#discussion_r1713350083
########## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ########## @@ -1259,7 +1260,6 @@ nonReserved | NON_NULLABLE | NULLS | OF - | OFFSET Review Comment: i don't think add reserved keyword to support non-mysql dialect is good idea. because doris use mysql protocol, so we should make doris as mysql like as possible. if want migrate from presto, use [doris sql convertor](https://doris.apache.org/zh-CN/docs/lakehouse/sql-dialect/) is a better way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org