LiBinfeng-01 commented on code in PR #39113:
URL: https://github.com/apache/doris/pull/39113#discussion_r1712615003
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4:
##########
@@ -72,6 +72,19 @@ lexer grammar DorisLexer;
public void markUnclosedComment() {
has_unclosed_bracketed_comment = true;
}
+
+ // This variable will hold the external state
+ private boolean channel2;
Review Comment:
when i let channel 2 always open, it would have problem when parsing because
in channel lexer would add some char before original string to let parser
ignore it. For example: it would make "/* leading(t1 t2) */" into "[@-1,15:36 =
'/leading(t1 t2) */', xxx" which when i want to parse it, i would meet eof
first then parse exit. So it make a switch to control this behavior
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilderForCreateView.java:
##########
@@ -56,6 +56,10 @@
/**LogicalPlanBuilderForCreateView*/
public class LogicalPlanBuilderForCreateView extends LogicalPlanBuilder {
+ public LogicalPlanBuilderForCreateView() {
+ super(null);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
