github-actions[bot] commented on code in PR #39022:
URL: https://github.com/apache/doris/pull/39022#discussion_r1710649068
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1381,34 +1593,28 @@ Status ColumnObject::merge_sparse_to_root_column() {
return Status::OK();
}
-void ColumnObject::finalize_if_not() {
- if (!is_finalized()) {
- finalize();
- }
-}
-
-void ColumnObject::finalize(bool ignore_sparse) {
+void ColumnObject::finalize(FinalizeMode mode) {
Review Comment:
warning: method 'finalize' can be made const
[readability-make-member-function-const]
be/src/vec/columns/column_object.h:370:
```diff
- void finalize(FinalizeMode mode);
+ void finalize(FinalizeMode mode) const;
```
```suggestion
void ColumnObject::finalize(FinalizeMode mode) const {
```
##########
be/src/vec/columns/column_object.h:
##########
@@ -19,6 +19,7 @@
// and modified by Doris
#pragma once
+#include <butil/compiler_specific.h>
Review Comment:
warning: 'butil/compiler_specific.h' file not found [clang-diagnostic-error]
```cpp
#include <butil/compiler_specific.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
