jacktengg commented on code in PR #39030:
URL: https://github.com/apache/doris/pull/39030#discussion_r1710575603
##########
be/src/vec/functions/function_cast.h:
##########
@@ -1541,8 +1541,9 @@ struct StringParsing {
res == StringParser::PARSE_OVERFLOW ||
res == StringParser::PARSE_UNDERFLOW);
} else if constexpr (IsDataTypeDateTimeV2<ToDataType>) {
- const auto* type = assert_cast<const DataTypeDateTimeV2*>(
- block.get_by_position(result).type.get());
+ const auto* type =
+ assert_cast<const DataTypeDateTimeV2*,
TypeCheckOnRelease::DISABLE>(
+ block.get_by_position(result).type.get());
Review Comment:
```
const DataTypeDateTimeV2* dtv2 = nullptr;
if constexpr (IsDataTypeDateTimeV2<ToDataType>) {
dtv2 =
assert_cast<const
DataTypeDateTimeV2*>(block.get_by_position(result).type.get());
}
for (size_t i = 0; i < row; ++i) {
... ...
if (...) {
} else if constexpr (IsDataTypeDateTimeV2<ToDataType>) {
parsed = try_parse_impl<ToDataType>(vec_to[i], read_buffer, context,
dtv2->get_scale());
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
