yiguolei commented on code in PR #39030: URL: https://github.com/apache/doris/pull/39030#discussion_r1709128114
########## be/src/vec/functions/function_helpers.h: ########## @@ -55,7 +55,7 @@ template <typename Type> const ColumnConst* check_and_get_column_const(const IColumn* column) { if (!column || !is_column_const(*column)) return {}; - const ColumnConst* res = assert_cast<const ColumnConst*>(column); Review Comment: maybe this not need because it already has may if logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org