xuchen-plus commented on code in PR #39044:
URL: https://github.com/apache/doris/pull/39044#discussion_r1708827977
##########
fe/fe-core/pom.xml:
##########
@@ -565,58 +565,87 @@ under the License.
<artifactId>hadoop-auth</artifactId>
</dependency>
+ <!-- lakesoul -->
<dependency>
<groupId>com.dmetasoul</groupId>
- <artifactId>lakesoul-common</artifactId>
+ <artifactId>lakesoul-io-java</artifactId>
<version>${lakesoul.version}</version>
- <classifier>shaded</classifier>
<exclusions>
<exclusion>
- <groupId>*</groupId>
+ <groupId>io.netty</groupId>
<artifactId>*</artifactId>
</exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>com.dmetasoul</groupId>
- <artifactId>lakesoul-io-java</artifactId>
- <version>${lakesoul.version}</version>
- <classifier>shaded</classifier>
- <exclusions>
<exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
+ <groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-vector</artifactId>
</exclusion>
<exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
+ <groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-memory-core</artifactId>
</exclusion>
<exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
+ <groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-memory-netty</artifactId>
</exclusion>
<exclusion>
<groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-format</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.spark</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
- <groupId>org.antlr</groupId>
- <artifactId>antlr4-runtime</artifactId>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>*</artifactId>
</exclusion>
<exclusion>
- <groupId>commons-logging</groupId>
- <artifactId>commons-logging</artifactId>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
+ <artifactId>*</artifactId>
</exclusion>
<exclusion>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>jsr305</artifactId>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>*</artifactId>
</exclusion>
<exclusion>
- <groupId>org.apache.spark</groupId>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.json4s</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.antlr</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.postgresql</groupId>
+ <artifactId>postgresql</artifactId>
+ <version>42.7.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-library</artifactId>
+ <version>${scala.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
1. postgresql is a dependency of lakesoul, and its version in lakesoul is
42.7.3. However in FE, the version will be overriden to 42.3.8 (by
spring-boot-dependencies I believe), which has CVE issues. So We override the
version again here.
2. scala-library is required by lakesoul in both compile and runtime, but
its original scope is provided. So we override the scope here.
3. antlr4 declaration here is unnecessary, I'll remove it and push again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
