zhannngchen commented on code in PR #39018:
URL: https://github.com/apache/doris/pull/39018#discussion_r1708541254
##########
be/src/cloud/cloud_txn_delete_bitmap_cache.h:
##########
@@ -42,7 +42,9 @@ class CloudTxnDeleteBitmapCache : public
LRUCachePolicyTrackingManual {
RowsetSharedPtr* rowset, DeleteBitmapPtr*
delete_bitmap,
RowsetIdUnorderedSet* rowset_ids, int64_t*
txn_expiration,
std::shared_ptr<PartialUpdateInfo>*
partial_update_info,
- std::shared_ptr<PublishStatus>* publish_status);
+ std::shared_ptr<PublishStatus>* publish_status,
Review Comment:
too many parameters, use struct TabletTxnInfo as parameter directly?
##########
be/src/cloud/cloud_txn_delete_bitmap_cache.h:
##########
@@ -52,7 +54,10 @@ class CloudTxnDeleteBitmapCache : public
LRUCachePolicyTrackingManual {
void update_tablet_txn_info(TTransactionId transaction_id, int64_t
tablet_id,
DeleteBitmapPtr delete_bitmap,
const RowsetIdUnorderedSet& rowset_ids,
- PublishStatus publish_status);
+ PublishStatus publish_status, int64_t
publish_version = -1,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
