This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 26bb014a845 [chore](S3Load) Add log for FE's list object operation
(#38948)
26bb014a845 is described below
commit 26bb014a845a2e2f273c8c5f1f092ab6c8c778c4
Author: AlexYue <yj976240...@gmail.com>
AuthorDate: Wed Aug 7 20:48:02 2024 +0800
[chore](S3Load) Add log for FE's list object operation (#38948)
---
fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java | 4 +++-
.../src/main/java/org/apache/doris/cloud/storage/AzureRemote.java | 2 +-
.../src/main/java/org/apache/doris/cloud/storage/DefaultRemote.java | 2 +-
.../src/main/java/org/apache/doris/cloud/storage/OssRemote.java | 2 +-
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
index a94fcb0d13c..373b320afa1 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java
@@ -652,11 +652,13 @@ public class LoadStmt extends DdlStmt {
private void checkAkSk() throws UserException {
RemoteBase remote = null;
ObjectInfo objectInfo = null;
+ String curFile = null;
try {
Map<String, String> brokerDescProperties =
brokerDesc.getProperties();
String provider = getProviderFromEndpoint();
for (DataDescription dataDescription : dataDescriptions) {
for (String filePath : dataDescription.getFilePaths()) {
+ curFile = filePath;
String bucket = getBucketFromFilePath(filePath);
objectInfo = new
ObjectInfo(ObjectStoreInfoPB.Provider.valueOf(provider.toUpperCase()),
brokerDescProperties.get(S3Properties.Env.ACCESS_KEY),
@@ -671,7 +673,7 @@ public class LoadStmt extends DdlStmt {
}
}
} catch (Exception e) {
- LOG.warn("Failed to access object storage, proto={}, err={}",
objectInfo, e.toString());
+ LOG.warn("Failed to access object storage, file={}, proto={},
err={}", curFile, objectInfo, e.toString());
throw new UserException(InternalErrorCode.GET_REMOTE_DATA_ERROR,
"Failed to access object storage", e);
} finally {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/AzureRemote.java
b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/AzureRemote.java
index 19629096737..62026b47b87 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/AzureRemote.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/AzureRemote.java
@@ -215,7 +215,7 @@ public class AzureRemote extends RemoteBase {
return new ListObjectsResult(objectFiles,
pagedResponse.getContinuationToken() != null,
pagedResponse.getContinuationToken());
} catch (BlobStorageException e) {
- LOG.warn("Failed to list objects for Azure", e);
+ LOG.warn("Failed to list objects for Azure prefix {}", prefix, e);
throw new DdlException("Failed to list objects for Azure, Error
message=" + e.getMessage());
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/DefaultRemote.java
b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/DefaultRemote.java
index f69204fab97..661caf88746 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/DefaultRemote.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/DefaultRemote.java
@@ -110,7 +110,7 @@ public class DefaultRemote extends RemoteBase {
}
return new ListObjectsResult(objectFiles, response.isTruncated(),
response.nextContinuationToken());
} catch (SdkException e) {
- LOG.warn("Failed to list objects for S3", e);
+ LOG.warn("Failed to list objects for S3, prefix {}", prefix, e);
throw new DdlException("Failed to list objects for S3, Error
message=" + e.getMessage());
}
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/OssRemote.java
b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/OssRemote.java
index 42e019c77ba..e44d462e3c1 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/OssRemote.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/cloud/storage/OssRemote.java
@@ -155,7 +155,7 @@ public class OssRemote extends DefaultRemote {
}
return new ListObjectsResult(objectFiles, result.isTruncated(),
result.getNextContinuationToken());
} catch (OSSException e) {
- LOG.warn("Failed to list objects for OSS", e);
+ LOG.warn("Failed to list objects for OSS prefix {}", prefix, e);
throw new DdlException("Failed to list objects for OSS, Error
code=" + e.getErrorCode() + ", Error message="
+ e.getErrorMessage());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
