github-actions[bot] commented on code in PR #38959:
URL: https://github.com/apache/doris/pull/38959#discussion_r1706335221


##########
be/src/vec/common/allocator.cpp:
##########
@@ -43,6 +43,11 @@
 std::unordered_map<void*, size_t> RecordSizeMemoryAllocator::_allocated_sizes;
 std::mutex RecordSizeMemoryAllocator::_mutex;
 
+template <bool clear_memory_, bool mmap_populate, bool use_mmap, typename 
MemoryAllocator>
+Allocator<clear_memory_, mmap_populate, use_mmap, 
MemoryAllocator>::Allocator() {

Review Comment:
   warning: use '= default' to define a trivial default constructor 
[modernize-use-equals-default]
   ```cpp
   Allocator<clear_memory_, mmap_populate, use_mmap, 
MemoryAllocator>::Allocator() {
                                                                       ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to