csun5285 commented on code in PR #38986:
URL: https://github.com/apache/doris/pull/38986#discussion_r1706307035


##########
be/src/cloud/cloud_warm_up_manager.cpp:
##########
@@ -114,6 +114,40 @@ void CloudWarmUpManager::handle_jobs() {
                                                 wait->signal();
                                             },
                             });
+
+                    // idx
+                    auto download_idx_file = [&](const io::Path& idx_path) {
+                        io::DownloadFileMeta meta {
+                                .path = idx_path,
+                                .file_size = -1,
+                                .file_system = storage_resource.value()->fs,
+                                .ctx =
+                                        {
+                                                .expiration_time = 
expiration_time,
+                                        },
+                                .download_done =
+                                        [wait](Status st) {
+                                            if (!st) {
+                                                LOG_WARNING("Warm up error 
").error(st);
+                                            }
+                                            wait->signal();
+                                        },
+                        };
+                        
_engine.file_cache_block_downloader().submit_download_task(std::move(meta));
+                    };
+                    auto idx_version = 
rs->tablet_schema()->get_inverted_index_storage_format();

Review Comment:
   if (rs->tablet_schema()->has_inverted_index())



##########
be/src/cloud/cloud_warm_up_manager.cpp:
##########
@@ -114,6 +114,40 @@ void CloudWarmUpManager::handle_jobs() {
                                                 wait->signal();
                                             },
                             });
+
+                    // idx
+                    auto download_idx_file = [&](const io::Path& idx_path) {

Review Comment:
   The `CloudTablet::add_rowsets` also requires this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to