gavinchou commented on code in PR #38939:
URL: https://github.com/apache/doris/pull/38939#discussion_r1705022901


##########
be/src/io/cache/block_file_cache_downloader.cpp:
##########
@@ -171,7 +171,8 @@ void FileCacheBlockDownloader::download_file_cache_block(
         DownloadFileMeta download_meta {
                 .path = 
storage_resource.value()->remote_segment_path(*find_it->second,
                                                                       
meta.segment_id()),
-                .file_size = meta.offset() + meta.size(), // To avoid trigger 
get file size IO
+                .file_size = meta.has_file_size() ? meta.file_size()
+                                                  : -1, // To avoid trigger 
get file size IO

Review Comment:
   incorrect comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to