github-actions[bot] commented on code in PR #38894:
URL: https://github.com/apache/doris/pull/38894#discussion_r1704416919
##########
be/src/olap/schema_change.cpp:
##########
@@ -368,78 +383,90 @@ Status BlockChanger::change_block(vectorized::Block*
ref_block,
return Status::OK();
}
-// This check is for MV to prevent schema-change from causing data loss
-Status BlockChanger::_check_cast_valid(vectorized::ColumnPtr ref_column,
- vectorized::ColumnPtr new_column,
AlterTabletType type) {
- if (ref_column->size() != new_column->size()) {
+// This check can prevent schema-change from causing data loss after type cast
+Status BlockChanger::_check_cast_valid(vectorized::ColumnPtr input_column,
Review Comment:
warning: function '_check_cast_valid' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status BlockChanger::_check_cast_valid(vectorized::ColumnPtr input_column,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/schema_change.cpp:386:** 85 lines including whitespace and
comments (threshold 80)
```cpp
Status BlockChanger::_check_cast_valid(vectorized::ColumnPtr input_column,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
