liaoxin01 commented on code in PR #38003:
URL: https://github.com/apache/doris/pull/38003#discussion_r1704005166
##########
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##########
@@ -651,9 +694,12 @@ Status VTabletWriterV2::_close_wait(bool incremental) {
<< print_id(_load_id);
return Status::TimedOut("load timed out before close
waiting");
}
- RETURN_IF_ERROR(stream->close_wait(_state, remain_ms));
+ auto st = stream->close_wait(_state, remain_ms);
+ if (!st.ok() && status.ok()) {
+ status = st;
+ }
}
- return Status::OK();
+ return status;
Review Comment:
Will there be a load_stram leak here? If there is an error, it will be
returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
