github-actions[bot] commented on code in PR #38828:
URL: https://github.com/apache/doris/pull/38828#discussion_r1703048367
##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -217,11 +176,10 @@ Status CloudSchemaChangeJob::process_alter_tablet(const
TAlterTabletReqV2& reque
std::make_pair(to_lower(item.column_name), mv_param));
}
sc_params.enable_unique_key_merge_on_write =
_new_tablet->enable_unique_key_merge_on_write();
- return _convert_historical_rowsets(sc_params, job);
+ return _convert_historical_rowsets(sc_params);
}
-Status CloudSchemaChangeJob::_convert_historical_rowsets(const
SchemaChangeParams& sc_params,
-
cloud::TabletJobInfoPB& job) {
+Status CloudSchemaChangeJob::_convert_historical_rowsets(const
SchemaChangeParams& sc_params) {
Review Comment:
warning: function '_convert_historical_rowsets' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status CloudSchemaChangeJob::_convert_historical_rowsets(const
SchemaChangeParams& sc_params) {
^
```
<details>
<summary>Additional context</summary>
**be/src/cloud/cloud_schema_change_job.cpp:181:** 205 lines including
whitespace and comments (threshold 80)
```cpp
Status CloudSchemaChangeJob::_convert_historical_rowsets(const
SchemaChangeParams& sc_params) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
