HappenLee commented on code in PR #38744: URL: https://github.com/apache/doris/pull/38744#discussion_r1701105499
########## be/src/vec/aggregate_functions/aggregate_function_sort.h: ########## @@ -158,7 +161,8 @@ class AggregateFunctionSort } void insert_result_into(ConstAggregateDataPtr targetplace, IColumn& to) const override { - auto place = const_cast<AggregateDataPtr>(targetplace); + auto* place = const_cast<AggregateDataPtr>(targetplace); Review Comment: the function should add interface `void insert_result_into(ConstAggregateDataPtr targetplace, IColumn& to, Area)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org