zclllyybb commented on issue #38333: URL: https://github.com/apache/doris/issues/38333#issuecomment-2263218611
> > cmake script is obviously harder to understand and modify than shells. could you explain what benifits will the refactor take? > > 1. Since the project's be already using CMake, all compilations within the project use CMake consistently. It is not good for C++ projects within a project to use several different management dependencies; > 2. All project libs use CMake and can share compilation parameters, instead of writing compilation parameters separately for each dependency; > 3. CMake can better manage dependencies. For example, A and B refer to C. If C is updated, CMake can sense that A and B are recompiled, but the shell needs to be manually operated; > 4. CMake has better platform consistency, e.g. sed is not compatibility between Linux and Darwin; that looks great. since that's a significant refactor, I think there should be a proposal in dev mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
