github-actions[bot] commented on code in PR #35181: URL: https://github.com/apache/doris/pull/35181#discussion_r1699950209
########## be/src/service/internal_service.cpp: ########## @@ -943,6 +951,156 @@ void PInternalService::test_jdbc_connection(google::protobuf::RpcController* con } } +static void handle_sigchld(int sig_no) { + for (;;) { + if (waitpid(-1, NULL, WNOHANG) == 0){ Review Comment: warning: use nullptr [modernize-use-nullptr] ```suggestion if (waitpid(-1, nullptr, WNOHANG) == 0){ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org