github-actions[bot] commented on code in PR #38686:
URL: https://github.com/apache/doris/pull/38686#discussion_r1699541058
##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -302,6 +302,12 @@ class RowsetMeta {
return num_segments() > 1 && is_singleton_delta() &&
segments_overlap() != NONOVERLAPPING;
}
+ bool produced_by_compaction() const {
Review Comment:
warning: function 'produced_by_compaction' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool produced_by_compaction() const {
```
##########
be/src/olap/rowset/rowset.h:
##########
@@ -165,6 +165,7 @@ class Rowset : public std::enable_shared_from_this<Rowset> {
bool is_segments_overlapping() const { return
rowset_meta()->is_segments_overlapping(); }
KeysType keys_type() { return _schema->keys_type(); }
RowsetStatePB rowset_meta_state() const { return
rowset_meta()->rowset_state(); }
+ bool produced_by_compaction() const { return
rowset_meta()->produced_by_compaction(); }
Review Comment:
warning: function 'produced_by_compaction' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
; }[[nodiscard]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
