github-actions[bot] commented on code in PR #38666:
URL: https://github.com/apache/doris/pull/38666#discussion_r1699364009
##########
be/src/exec/schema_scanner.cpp:
##########
@@ -84,7 +88,60 @@ Status SchemaScanner::start(RuntimeState* state) {
return Status::OK();
}
-Status SchemaScanner::get_next_block(vectorized::Block* block, bool* eos) {
+Status SchemaScanner::get_next_block(RuntimeState* state, vectorized::Block*
block, bool* eos) {
Review Comment:
warning: pointer parameter 'eos' can be pointer to const
[readability-non-const-parameter]
be/src/exec/schema_scanner.h:101:
```diff
- Status get_next_block(RuntimeState* state, vectorized::Block* block,
bool* eos);
+ Status get_next_block(RuntimeState* state, vectorized::Block* block,
const bool* eos);
```
```suggestion
Status SchemaScanner::get_next_block(RuntimeState* state, vectorized::Block*
block, const bool* eos) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
