gavinchou commented on code in PR #37293:
URL: https://github.com/apache/doris/pull/37293#discussion_r1699310736


##########
be/src/cloud/cloud_cumulative_compaction.cpp:
##########
@@ -48,7 +48,8 @@ 
CloudCumulativeCompaction::CloudCumulativeCompaction(CloudStorageEngine& engine,
 CloudCumulativeCompaction::~CloudCumulativeCompaction() = default;
 
 Status CloudCumulativeCompaction::prepare_compact() {
-    if (_tablet->tablet_state() != TABLET_RUNNING) {
+    if (_tablet->tablet_state() != TABLET_RUNNING && 
config::enable_new_tablet_do_compaction &&

Review Comment:
   !config::enable_new_tablet_do_compaction
   add a regression test to cover enable_new_tablet_do_compaction = false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to