morrySnow commented on code in PR #38525:
URL: https://github.com/apache/doris/pull/38525#discussion_r1698220761


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java:
##########
@@ -636,6 +636,7 @@ public void addPartitionsCache(String dbName, String 
tblName, List<String> parti
         HivePartitionValues copy = partitionValues.copy();
         Map<Long, PartitionItem> idToPartitionItemBefore = 
copy.getIdToPartitionItem();
         Map<String, Long> partitionNameToIdMapBefore = 
copy.getPartitionNameToIdMap();
+        Map<Long, String> partitionIdToNameMapBefore = 
copy.getPartitionIdToNameMap();

Review Comment:
   both id and name should be unique, may be better to use bimap to avoid 
inconsistent bewteen them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to