This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 1d076635ba4ea7ea5c743723eed269483974435a
Author: amory <wangqian...@selectdb.com>
AuthorDate: Thu Jul 25 22:03:22 2024 +0800
[fix](map)fix log message in tablet_schema (#38254)
---
be/src/olap/tablet_schema.cpp | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/be/src/olap/tablet_schema.cpp b/be/src/olap/tablet_schema.cpp
index c27db2bd3d9..b3dde488674 100644
--- a/be/src/olap/tablet_schema.cpp
+++ b/be/src/olap/tablet_schema.cpp
@@ -550,11 +550,18 @@ void TabletColumn::init_from_pb(const ColumnPB& column) {
_visible = column.visible();
}
if (_type == FieldType::OLAP_FIELD_TYPE_ARRAY) {
- CHECK(column.children_columns_size() == 1) << "ARRAY type has more
than 1 children types.";
+ CHECK(column.children_columns_size() == 1)
+ << "ARRAY type should has 1 children types, but got "
+ << column.children_columns_size();
}
if (_type == FieldType::OLAP_FIELD_TYPE_MAP) {
- DCHECK(column.children_columns_size() == 2) << "MAP type has more than
2 children types.";
- LOG(WARNING) << "MAP type has more than 2 children types.";
+ DCHECK(column.children_columns_size() == 2)
+ << "MAP type should has 2 children types, but got "
+ << column.children_columns_size();
+ if (UNLIKELY(column.children_columns_size() != 2)) {
+ LOG(WARNING) << "MAP type should has 2 children types, but got "
+ << column.children_columns_size();
+ }
}
for (size_t i = 0; i < column.children_columns_size(); i++) {
TabletColumn child_column;
@@ -621,11 +628,15 @@ void TabletColumn::to_schema_pb(ColumnPB* column) const {
column->set_visible(_visible);
if (_type == FieldType::OLAP_FIELD_TYPE_ARRAY) {
- CHECK(_sub_columns.size() == 1) << "ARRAY type has more than 1
children types.";
+ CHECK(_sub_columns.size() == 1)
+ << "ARRAY type should has 1 children types, but got " <<
_sub_columns.size();
}
if (_type == FieldType::OLAP_FIELD_TYPE_MAP) {
- DCHECK(_sub_columns.size() == 2) << "MAP type has more than 2 children
types.";
- LOG(WARNING) << "MAP type has more than 2 children types.";
+ DCHECK(_sub_columns.size() == 2)
+ << "MAP type should has 2 children types, but got " <<
_sub_columns.size();
+ if (UNLIKELY(_sub_columns.size() != 2)) {
+ LOG(WARNING) << "MAP type should has 2 children types, but got "
<< _sub_columns.size();
+ }
}
for (size_t i = 0; i < _sub_columns.size(); i++) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
