englefly commented on code in PR #38534: URL: https://github.com/apache/doris/pull/38534#discussion_r1697144752
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpJoinFromUnion.java: ########## @@ -403,8 +404,9 @@ private boolean tryMapJoinSlotToUnion(LogicalUnion union, List<Pair<LogicalJoin< } Review Comment: 如果expr 不在regular 里面,那就不应该有这个expr了吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org