github-actions[bot] commented on code in PR #38376: URL: https://github.com/apache/doris/pull/38376#discussion_r1696239730
########## be/src/vec/functions/array/function_array_contains_all.cpp: ########## @@ -0,0 +1,267 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <fmt/format.h> +#include <glog/logging.h> + +#include <type_traits> + +#include "common/status.h" +#include "vec/common/assert_cast.h" +#include "vec/data_types/data_type_array.h" +#include "vec/data_types/data_type_number.h" +#include "vec/functions/array/function_array_utils.h" +#include "vec/functions/function.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +class FunctionArrayContainsAll : public IFunction { +public: + static constexpr auto name = "array_contains_all"; + static FunctionPtr create() { return std::make_shared<FunctionArrayContainsAll>(); } + + String get_name() const override { return name; } + + bool use_default_implementation_for_nulls() const override { return true; } + + bool is_variadic() const override { return false; } + + size_t get_number_of_arguments() const override { return 2; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + auto left_data_type = remove_nullable(arguments[0]); + auto right_data_type = remove_nullable(arguments[1]); + DCHECK(is_array(left_data_type)) << arguments[0]->get_name(); + DCHECK(is_array(right_data_type)) << arguments[1]->get_name(); + auto left_nested_type = remove_nullable( + assert_cast<const DataTypeArray&>(*left_data_type).get_nested_type()); + auto right_nested_type = remove_nullable( + assert_cast<const DataTypeArray&>(*right_data_type).get_nested_type()); + DCHECK(left_nested_type->equals(*right_nested_type)) + << "data type " << arguments[0]->get_name() << " not equal with " + << arguments[1]->get_name(); + return std::make_shared<DataTypeUInt8>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, Review Comment: warning: function 'execute_impl' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, ^ ``` <details> <summary>Additional context</summary> **be/src/vec/functions/array/function_array_contains_all.cpp:60:** 120 lines including whitespace and comments (threshold 80) ```cpp Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
